-
Notifications
You must be signed in to change notification settings - Fork 654
[Improvement] Rename default master
branch to main
#2570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yes, 👍🏼 from me. |
Seems like a good idea to me! |
Whats the benefit? |
There's a lot of good information here, @dazinator. |
Oh dear. Politics. |
@arturcic is this a "visual" / GitVersion branch change only or also a behavioral runtime change in how GitVersion works? The reason I ask is because I see lots of unit tests changing from master => main but I think we should actually duplicate and test both master and main (and leave it it to the users whether they want to go ahead with this "main branch thing"). |
@GeertvanHorrik the tests internally use |
That means projects that were using the GitVersion before this change will continue to work |
Thanks for the explanation, then I don't mind, as long as it's not a breaking change for people sticking with master 👍 |
🎉 This issue has been resolved in version 5.6.5 🎉 Your GitReleaseManager bot 📦🚀 |
Just an FYI I found that this causes a failure when using a branch configuration that currently references assembly-versioning-scheme: MajorMinorPatch
mode: ContinuousDeployment
continuous-delivery-fallback-tag: ci
next-version: 0.1.0
branches:
next:
regex: ^next$
mode: ContinuousDeployment
tag: next
increment: Major
prevent-increment-of-merged-branch-version: false
track-merge-target: false
tracks-release-branches: false
is-release-branch: false
source-branches: ['master']
ignore:
sha: [] |
@david-driscoll, this should have been fixed in #2588. |
GitHub already added the feature to rename the default branch and re-target the PRs on the new default branch.
@GitTools/developers do you agree with that?
It will require also adapting the build scripts and maybe the code itself
The text was updated successfully, but these errors were encountered: