Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release branch results in wrong version (default strategy is patch) #1897

Closed
GeertvanHorrik opened this issue Nov 7, 2019 · 3 comments · Fixed by #1899
Closed

Release branch results in wrong version (default strategy is patch) #1897

GeertvanHorrik opened this issue Nov 7, 2019 · 3 comments · Fixed by #1899
Assignees
@GeertvanHorrik
Labels
bug
Milestone
5.1.2

Comments

@GeertvanHorrik
Copy link
Contributor

We have version 5.12.0 (release/5.12.0)

Then we commit on develop and release/5.12.0. The resulting version is 5.12.1, which is incorrect.

Will investigate and create a fix.
@GeertvanHorrik GeertvanHorrik self-assigned this Nov 7, 2019
@GeertvanHorrik
Copy link
Contributor Author

The PrereleaseTag is null on the feature branch, I think it should be beta.

@GeertvanHorrik
Copy link
Contributor Author

config.TrackReleaseBranches somehow is false.

@GeertvanHorrik
Copy link
Contributor Author

I think the issue is in ConfigExtensions::ApplyBranchDefaults. The default increment strategy for release branches is Patch, I don't think that's correct.

@GeertvanHorrik GeertvanHorrik changed the title Dynamic repositories combined with release branch results in wrong version Release branch results in wrong version (default strategy is patch) Nov 7, 2019
@GeertvanHorrik GeertvanHorrik mentioned this issue Nov 7, 2019
Merged
@arturcic arturcic added this to the 5.1.2 milestone Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GeertvanHorrik GeertvanHorrik

Labels
bug
Projects
None yet
Milestone
5.1.2
Development

Successfully merging a pull request may close this issue.

Change default increment strategy for release branches to None instead of Patch GitTools/GitVersion
2 participants
@GeertvanHorrik @arturcic