Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish new version w/ updated prop-types to remove fbjs dependency? #46

Open
wyantb opened this issue Nov 8, 2019 · 0 comments
Open

Comments

@wyantb
Copy link

wyantb commented Nov 8, 2019

I have a project in which I'm not importing fbjs today. Indeed, in the latest prop-types, they don't use it either - see https://github.com/facebook/prop-types/blob/953ed9beb0f15498cd7e6e25c90f7cadd5f2149a/CHANGELOG.md#1562 facebook/prop-types#194 for some background information. However, it seems that at the time mui-places-autocomplete was last published, fbjs was still used via prop-types and simply not listed in the package.json. If you could publish a new version with the latest prop-types package to remove the fbjs dependency entirely, that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant