New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cython: conditional compilation deprecated #343

Open

MuellerSeb opened this issue Apr 8, 2024 · 2 comments

Milestone

Member

MuellerSeb commented Apr 8, 2024

cython/cython#4310

The conditional compilation introduced in #336 are deprecated by cython.
I capped the cython version in #340 for now.

@LSchueler this should be cleaned up at some point.

MuellerSeb added this to the 1.6 milestone

Member Author

MuellerSeb commented Apr 16, 2024

Also cython_lint fails to read these files.

Member Author

MuellerSeb commented Apr 22, 2024

scikit learn has also solved this issue, but with an openmp helper module: https://github.com/scikit-learn/scikit-learn/blob/0c72e5448b9da3b0d9202aa5a2abbd9bff4c238a/sklearn/utils/_openmp_helpers.pyx#L25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment