Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Krige: add switch to select variogram or covariance #191

Open
MuellerSeb opened this issue Jul 7, 2021 · 1 comment
Open

Krige: add switch to select variogram or covariance #191

MuellerSeb opened this issue Jul 7, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@MuellerSeb
Copy link
Member

Currently, the kriging matrix is build on the covariance function of the given model:

res[: self.cond_no, : self.cond_no] = self.model.covariance(

To be future prove, we should add a switch to be able to select the variogram function as well.

For unbounded variograms (not supported at the moment) we can't express the kriging system by the covariance (not well defined then).
Unbounded variograms are already supported by PyKrige and we need to support them: GeoStat-Framework/PyKrige#136 (comment)

Further, this could maybe be helpful for some numerical problems, but I am just guessing here.

@MuellerSeb MuellerSeb added the enhancement New feature or request label Jul 7, 2021
@MuellerSeb MuellerSeb added this to the 2.0 milestone Jul 7, 2021
@MuellerSeb MuellerSeb self-assigned this Jul 7, 2021
@MuellerSeb MuellerSeb added this to I14Y in GS-Framework v2 Jul 7, 2021
@MuellerSeb MuellerSeb pinned this issue Jul 7, 2021
@MuellerSeb MuellerSeb changed the title Krige: add switch to select use of variogram or covariance for kriging matrix Krige: add switch to select use of variogram or covariance Jul 7, 2021
@MuellerSeb MuellerSeb changed the title Krige: add switch to select use of variogram or covariance Krige: add switch to select variogram or covariance Jul 7, 2021
@MuellerSeb
Copy link
Member Author

MuellerSeb commented Jul 13, 2021

Note

When setting unbiased=False (simple kriging), we can't use the variogram formulation, since the kriging weights need to sum up to 1 (unbiased condition) in order to transform the kriging system from the covariance formulation to the variogram formulation.

Consequently, simple kriging is not possible with unbounded models.

@MuellerSeb MuellerSeb modified the milestones: 2.0, v1.3.3 Jul 27, 2021
@MuellerSeb MuellerSeb modified the milestones: 1.3.3, 2.0 Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant