-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GeoPandas: Migrate the engine from fiona to pyogrio #3231
Comments
We also have some mysterious failures with Fiona as mentioned in #3180 (comment). Migrating from Fiona to pyogrio also help us avoid such failures. |
Not sure if we can migrate completely away from |
OGR_GMT is built-in by default in GDAL (https://gdal.org/drivers/vector/gmt.html), so we should be safe unless some package distributors decide to disable OGR_GMT explicitly. |
Ok, opened a proof of concept PR at #3237 to switch from fiona to pyogrio. The way it works is that we get a GeoJSON representation from Downside is that this means geopandas would become a stronger optional dependency. Before, someone could install just fiona without geopandas and plot shapely objects, but now, doing so via pyogrio would require geopandas. |
Maybe we can try geopandas first, then pyogrio, then fiona? But we may still see fiona errors reported in #3180 (comment). |
GeoPandas v1.0.0-alpha1 has been released (https://geopandas.org/en/latest/docs/changelog.html#version-1-0-0-alpha1-apr-13-2024). The biggest change is that the default I/O engine is changed from Fiona to pyogrio.
So, when geopandas v1.0.0 is released, PyGMT will fail to work, because:
scheme
parameter so some codes will break.I think we should start the migration now following the instructions.
pyogrio
as a optional dependency since geopandas 0.x doesn't install it by defaultengine="pyogrio"
to use the pyogrioThoughts @GenericMappingTools/pygmt-maintainers especially @weiji14?
The text was updated successfully, but these errors were encountered: