Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to official GitHub action for managing app tokens #3164

Closed
seisman opened this issue Apr 10, 2024 · 3 comments · Fixed by #3165
Closed

Switch to official GitHub action for managing app tokens #3164

seisman opened this issue Apr 10, 2024 · 3 comments · Fixed by #3165
Labels
help wanted Helping hands are appreciated maintenance Boring but important stuff for the core devs
Milestone

Comments

@seisman
Copy link
Member

seisman commented Apr 10, 2024

Currently, we're using the tibdex/github-app-token action to generate PAT tokens which are used in the /format slash command (initially proposed in #645 (comment)).

It seems that GitHub now provides an official action for this purpose (https://github.com/actions/create-github-app-token). I think we should try to switch to the official one. Looking at this PR (dependabot/dependabot-core#9340), it seems we just need to update the action name and the action input names.

xref:

@seisman seisman added maintenance Boring but important stuff for the core devs help wanted Helping hands are appreciated labels Apr 10, 2024
@yvonnefroehlich
Copy link
Member

Meaning changing

# Generate token from GenericMappingTools bot
- uses: tibdex/github-app-token@v2
id: generate-token
with:
app_id: ${{ secrets.APP_ID }}
private_key: ${{ secrets.APP_PRIVATE_KEY }}

to

      # Generate token from GenericMappingTools bot
      - uses: actions/create-github-app-token@v1.9
        id: generate-token
        with:
          app-id: ${{ secrets.APP_ID }}
          private-key: ${{ secrets.APP_PRIVATE_KEY }}

@seisman
Copy link
Member Author

seisman commented Apr 10, 2024

Yes, that should work.

@yvonnefroehlich
Copy link
Member

Yes, that should work.

Thank! I summited PR #3165 with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Helping hands are appreciated maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants