Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore generated files #136

Closed
urandom2 opened this issue Mar 4, 2019 · 2 comments · Fixed by #139
Closed

ignore generated files #136

urandom2 opened this issue Mar 4, 2019 · 2 comments · Fixed by #139

Comments

@urandom2
Copy link
Contributor

urandom2 commented Mar 4, 2019

description

rice includes all files from requested FindBox directory, I noticed in #135 this can become problematic if generated files or binaries get accidentially included.

While #37/#83 or #47 could help with this, it feels pretty straight forward to at least exclude the rules from rice clean.

@GeertJohan
Copy link
Owner

This could work indeed. Would you be willing to create a PR for this?

@urandom2
Copy link
Contributor Author

urandom2 commented Mar 20, 2019

Happily, I think the low hanging fruit is the rice generated files, and that should not be too hard.

Detecting go binaries and ignoring go source could lead to false positives, so if you have any ideas let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants