Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all artifacts matching the glob are deleted #22

Open
joernott opened this issue Feb 6, 2024 · 3 comments
Open

Not all artifacts matching the glob are deleted #22

joernott opened this issue Feb 6, 2024 · 3 comments

Comments

@joernott
Copy link

joernott commented Feb 6, 2024

Context:
I am currently reworking a workflow to use with the v4 versions of upload/download-artifact and was relying heavily on adding content to artifacts before. So I settled for creating lots of unique little artifacts and combining them for the user at the very end of my workflow, where I use those tiny bits to generate a couple of reports. I use download-artifact to download all artifacts matching the pattern "testplan-", then I generate some reports from all the snippets and combine everything into an artifact "testplan". Afterwards, I want to delete everything matching "testplan-" to clean up.

Problem:
Some but not all artifacts matching the pattern are deleted. Example:

Run actions/download-artifact@v4
  with:
    pattern: testplan-*
    merge-multiple: true

downloads 32 artifacts, matching the various matrix runs. The subsequent

Run geekyeggo/delete-artifact@v4
  with:
    name: testplan-*
    useGlob: true
    failOnError: false

then deletes 18 of them, leaving the rest to dry. Do you have any idea, why this is happening?

@joernott
Copy link
Author

joernott commented Feb 6, 2024

I have added a "sleep 60" step before the deletion to avoid problems with github being slow to actually show the artifacts but the result is identical.

The artifacts which could be downnloaded are these:

  • testplan-210-report-sonarcloud--PHP8.0_MYSQL5.7 (ID: 1224470166, Size: 735)
  • testplan-120-test-codeception-codeception_acceptance_oe_moduletemplate-PHP8.1_MYSQL8.0 (ID: 1224466468, Size: 9643)
  • testplan-120-test-codeception-codeception_acceptance_oe_moduletemplate-PHP8.1_MYSQL5.7 (ID: 1224460112, Size: 9688)
  • testplan-120-test-codeception-codeception_acceptance_oe_moduletemplate-PHP8.0_MYSQL8.0 (ID: 1224454703, Size: 9688)
  • testplan-120-test-codeception-codeception_acceptance_oe_moduletemplate-PHP8.0_MYSQL5.7 (ID: 1224448521, Size: 9700)
  • testplan-230-report-styles-default-PHP8.0_MYSQL5.7 (ID: 1224446516, Size: 9323)
  • testplan-110-test-phpunit-unit_tests_oe_moduletemplate-PHP8.1_MYSQL5.7 (ID: 1224446403, Size: 9589)
  • testplan-110-test-phpunit-integration_tests-oe_moduletemplate-PHP8.0_MYSQL8.0 (ID: 1224446282, Size: 9652)
  • testplan-110-test-phpunit-integration_tests-oe_moduletemplate-PHP8.1_MYSQL8.0 (ID: 1224446220, Size: 9613)
  • testplan-110-test-phpunit-integration_tests-oe_moduletemplate-PHP8.0_MYSQL5.7 (ID: 1224446195, Size: 9628)
  • testplan-110-test-phpunit-unit_tests_oe_moduletemplate-PHP8.0_MYSQL5.7 (ID: 1224446141, Size: 9556)
  • testplan-110-test-phpunit-unit_tests_oe_moduletemplate-PHP8.0_MYSQL8.0 (ID: 1224446129, Size: 9576)
  • testplan-110-test-phpunit-integration_tests-oe_moduletemplate-PHP8.1_MYSQL5.7 (ID: 1224446000, Size: 9634)
  • testplan-110-test-phpunit-unit_tests_oe_moduletemplate-PHP8.1_MYSQL8.0 (ID: 1224445904, Size: 9521)
  • testplan-250-report-actionlint--PHP_MYSQL (ID: 1224443169, Size: 693)
  • testplan-240-report-yamllint--PHP_MYSQL (ID: 1224442991, Size: 682)
  • testplan-200-report---default-PHP0_MYSQL0 (ID: 1224442188, Size: 249)
  • testplan-100-test---default-PHP0_MYSQL0 (ID: 1224442186, Size: 242)
  • testplan-030-install-install_module-oe_moduletemplate-PHP8.0_MYSQL8.0 (ID: 1224434547, Size: 5652)
  • testplan-030-install-install_module-oe_moduletemplate-PHP8.1_MYSQL5.7 (ID: 1224434477, Size: 5647)
  • testplan-030-install-install_module-oe_moduletemplate-PHP8.1_MYSQL8.0 (ID: 1224434468, Size: 5617)
  • testplan-030-install-install_module-oe_moduletemplate-PHP8.0_MYSQL5.7 (ID: 1224434399, Size: 5633)
  • testplan-020-install-install_shop-default-PHP8.1_MYSQL5.7 (ID: 1224421754, Size: 1732)
  • testplan-020-install-install_shop-default-PHP8.1_MYSQL8.0 (ID: 1224421606, Size: 1730)
  • testplan-020-install-install_shop-default-PHP8.0_MYSQL8.0 (ID: 1224421521, Size: 1727)
  • testplan-020-install-install_shop-default-PHP8.0_MYSQL5.7 (ID: 1224421420, Size: 1732)
  • testplan-010-install-prepare_shop-default-PHP8.1_MYSQL8.0 (ID: 1224408625, Size: 874)
  • testplan-010-install-prepare_shop-default-PHP8.0_MYSQL5.7 (ID: 1224407841, Size: 874)
  • testplan-010-install-prepare_shop-default-PHP8.1_MYSQL5.7 (ID: 1224407833, Size: 874)
  • testplan-010-install-prepare_shop-default-PHP8.0_MYSQL8.0 (ID: 1224407821, Size: 871)
  • testplan-001-install---default-PHP0_MYSQL0 (ID: 1224396107, Size: 728)
  • testplan-000_header (ID: 1224396079, Size: 21408)

and the artifacts which got deleted are these:

  • testplan-000_header
  • testplan-001-install---default-PHP0_MYSQL0
  • testplan-010-install-prepare_shop-default-PHP8.0_MYSQL8.0
  • testplan-010-install-prepare_shop-default-PHP8.1_MYSQL5.7
  • testplan-010-install-prepare_shop-default-PHP8.0_MYSQL5.7
  • testplan-010-install-prepare_shop-default-PHP8.1_MYSQL8.0
  • testplan-020-install-install_shop-default-PHP8.0_MYSQL5.7
  • testplan-020-install-install_shop-default-PHP8.0_MYSQL8.0
  • testplan-020-install-install_shop-default-PHP8.1_MYSQL8.0
  • testplan-020-install-install_shop-default-PHP8.1_MYSQL5.7
  • testplan-030-install-install_module-oe_moduletemplate-PHP8.0_MYSQL5.7
  • testplan-030-install-install_module-oe_moduletemplate-PHP8.1_MYSQL8.0
  • testplan-030-install-install_module-oe_moduletemplate-PHP8.1_MYSQL5.7
  • testplan-030-install-install_module-oe_moduletemplate-PHP8.0_MYSQL8.0
  • testplan-100-test---default-PHP0_MYSQL0
  • testplan-200-report---default-PHP0_MYSQL0
  • testplan-240-report-yamllint--PHP_MYSQL
  • testplan-250-report-actionlint--PHP_MYSQL

I don't see an obvious pattern in the remaining files (made them bold in the first list)

@opicacek
Copy link

opicacek commented Feb 7, 2024

I am experiencing the same issue after upgrade to v4. Not all cache artifacts that matches the naming pattern are deleted 😕

@Avimitin
Copy link

Experiencing same issue here. There are 70 artifacts created by actions matrix, all have matrix id as suffix like "test-artifact-id". However specifying "test-artifact-*" only delete 20 on them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants