Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid panic when counting zero-sized outputs in count() #1618

Merged
merged 2 commits into from Jan 15, 2023

Conversation

Shadow53
Copy link
Contributor

Prerequisites

Resolves #1617.

  • Added a test case to tests/issues.rs
  • I also annotated an unrelated test-looking function with #[test] since it looked like it should be marked as such

Code style

This project follows a code style
checked by [rustfmt][https://github.com/rust-lang-nursery/rustfmt].

Please avoid cosmetic fixes unrelated to the pull request. Keeping the changes
as small as possible increase your chances of getting this merged quickly.

There were a couple of files that were modified by cargo fmt that I did not edit, so I undid those changes.

@Shadow53 Shadow53 requested a review from Geal as a code owner January 10, 2023 05:39
@Geal Geal changed the base branch from main to 7.x January 15, 2023 19:05
@Geal Geal changed the base branch from 7.x to main January 15, 2023 19:06
@Geal Geal merged commit 931bcf0 into rust-bakery:main Jan 15, 2023
@Geal
Copy link
Collaborator

Geal commented Jan 15, 2023

Thanks!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3880565977

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 62.485%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/multi/mod.rs 1 2 50.0%
Totals Coverage Status
Change from base Build 3863115493: 0.02%
Covered Lines: 1559
Relevant Lines: 2495

💛 - Coveralls

Geal pushed a commit that referenced this pull request Jan 15, 2023
* avoid panic when counting zero-sized outputs in count()

* run cargo fmt
Geal pushed a commit that referenced this pull request Jan 15, 2023
* avoid panic when counting zero-sized outputs in count()

* run cargo fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

count panics when parser returns zero-sized ()
3 participants