-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide feature toggle for escaping test messages in report (#53) #128
Comments
Hi @GitSIPA ! Thank you for this issue. Also adding custom logging seems to me quite a good feature too. I was thinking about it but didn't have enough time to implement it properly. The idea was to add custom logger to support real-time test messages (for example in markdown) |
Hi @GitSIPA ! For the test output with some |
If you want to try this locally now, you can do the following things:
@GitSIPA, please let me know if you want to try this out locally Thank you |
Hi @elv1s42 ! Thanks for implementing this enhancement. thank you! |
The changes are in |
This is now released as part of version |
Released. |
Problem
With the release of #53 we noticed a problem in our test reports and the way we currently use GHPReporter with NUnit.
When we first started using GHPReporter we noticed that adding HTML elements and styling was possible for test messages. We thought it was a feature and took advantage of it.
We implemented a LogInterface on our side that nicely formats our test logs that are written during the test and adds HTML elements as well
Suggested/Requested Solution
In order to continue using the latest version of GHPReporter in the future, we would need some kind of feature toggle that we can set, so that escaping test messages is turned off for us.
If this is not possible, we would have to look for a different reporting solution for our tests, since the workaround to just keep an old verison of \src\js\ghpr.conroller is not a valid long term solution for us
Example of our Report Usage
due to corporate guidelines I had to anonymize parts of the screenshot
The text was updated successfully, but these errors were encountered: