Storybook - first-child is potentially unsafe.

[petertgiles]

Observed in storybook, in the common project:

[mnigh]

There are only two references to the pseudo class :first-child in the codebase and neither are part of the Button component but rather the Dialog component's css: https://github.com/GCTC-NTGC/gc-digital-talent/blob/main/frontend/common/src/components/Dialog/dialog.css#L48,L49

In any case, this seems to be an issue with the version of storybook (v6.4.16) we are currently using, as well as some other versions of storybook:

• The pseudo class ":first-child" is potentially unsafe when doing server-side rendering.  storybookjs/storybook#6998
• The pseudo class ":first-child" is potentially unsafe when doing server-side rendering. Try changing it to ":first-of-type". storybookjs/storybook#18103

Solution

Upgrade to v6.5.8

[mnigh]

@vd1992 any guess on an estimate for this issue?

[vd1992]

I'll just stick a 1 on it