Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Differ.diff_with_options into Differ.diff and check input types #229

Open
EnricoMi opened this issue Jan 27, 2024 · 0 comments
Open

Merge Differ.diff_with_options into Differ.diff and check input types #229

EnricoMi opened this issue Jan 27, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@EnricoMi
Copy link
Contributor

These two methods can be merged / overloaded by checking input argument. Unexpected types should raise a useful error message #228. The diff_with_options method can be deprecated.
@EnricoMi EnricoMi added enhancement New feature or request good first issue Good for newcomers labels Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EnricoMi