Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XSS Vuln: HTML Email Templates Don't Auto-escape #2715

Open
mancusi opened this issue Apr 16, 2024 · 0 comments
Open

XSS Vuln: HTML Email Templates Don't Auto-escape #2715

mancusi opened this issue Apr 16, 2024 · 0 comments

Comments

@mancusi
Copy link

mancusi commented Apr 16, 2024

XSS Vuln: HTML Email Templates Don't Auto-escape

Description

Custom HTML email templates don't have a Freemarker output format set by default which results in the templates not auto-escaping templates by default

Observed versions

1.49.2

Affects versions

1.49.2

Steps to reproduce

Steps to reproduce the behavior:

  1. Create an email template with the following HTML
<html>
  <body>
    <p>Output format: ${.output_format}</p>
    <p>Auto-escaping: ${.auto_esc?c}</p>
    <p>Hi ${user.firstName}!</p>
  </body>
</html>
  1. Create a user with a first name of <h1>John</h1>
  2. Send a test email to them.

Expected behavior

<h1>John</h1> should be html escaped. However, no output format is set so an output format must be set manually. See Freemarker docs for details here.

Screenshots

Example email:
image

Platform

(Please complete the following information)

  • Device: any
  • OS: any
  • Browser + version: any
  • Database: any

Community guidelines

All issues filed in this repository must abide by the FusionAuth community guidelines.

Additional context

The output format and auto-escaping values in the example are provided to demonstrate that no output format is being set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mancusi