Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(grunt-purgecss): Fix plugin not ouputting all files #723

Merged
merged 4 commits into from Jul 31, 2021

Conversation

vnctaing
Copy link
Contributor

@vnctaing vnctaing commented Jul 30, 2021

Proposed changes

Attempting to fix #619 I think there was a concurrency issue. I've added a failling test. I tried this fix : wait for all results before finishing the grunt task and returning the output.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Is there any rules around styling for accepting my PR ?

@Ffloriel Ffloriel merged commit 646e419 into FullHuman:master Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grunt purgecss doesn't execute on all files when more than two.
2 participants