Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all tooling configuration to Build dir #1202

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

lukaszuznanski
Copy link
Contributor

Resolve: #1186

@oliverklee
Copy link
Contributor

I think this deserves an entry in the changelog. What do you think?

@oliverklee
Copy link
Contributor

@sbuerk provided some more feedback and recommends to not use config/ for this as this by convention is the production configuration folder for TYPO3 sites. I'll put this up for decision in the next call.

@lukaszuznanski
Copy link
Contributor Author

Ok, I'm not sure if this was decided, can't find it in meeting minutes

@lukaszuznanski
Copy link
Contributor Author

@oliverklee @sbuerk should we use Build/ ?

@sbuerk
Copy link
Collaborator

sbuerk commented May 7, 2024

@oliverklee @sbuerk should we use Build/ ?

If you ask me, yes. That's also the folder the TYPO3 core uses for these things of tool configurations (with sub-folders per tool) and core merger/contributors adopted for extensions and projects.

I talked with @oliverklee and @DanielSiepmann on that already. In the end, it's about naming with some requirements:

  • folder to keep root-folder clean
  • not using a folder name which contains extension related stuff (ex. Configuration/ ) in the TYPO3 world

There are other preferences, which you should discuss/define within the team first I guess. For example stying on the root-folder / default naming.

Personally, Build/ suits most perfectly for these kind of stuff. I would stay way from things like etc/ or namings used in other contexts not suiting the need.

@lukaszuznanski lukaszuznanski changed the title Move all tooling configuration to config dir Move all tooling configuration to .Build dir May 20, 2024
@lukaszuznanski lukaszuznanski changed the title Move all tooling configuration to .Build dir Move all tooling configuration to Build dir May 20, 2024
@lukaszuznanski lukaszuznanski force-pushed the TASK/Move-tooling-configuration-to-config-dir branch from 6f0be0f to b6bb438 Compare May 20, 2024 20:46
@coveralls
Copy link

coveralls commented May 20, 2024

Pull Request Test Coverage Report for Build 9165103416

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9164456450: 0.0%
Covered Lines: 46
Relevant Lines: 46

💛 - Coveralls

@oliverklee
Copy link
Contributor

I propose we split this PR up into "one tool per PR". This makes the reviews easier, reduces the risk of us missing things, and helps get the changes merged faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put all tooling configuration files into one directory config/
4 participants