Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated unittests break with phpunit 9 (required by the v10 testingframework) #436

Closed
cypelt opened this issue Aug 5, 2021 · 0 comments · Fixed by #441
Closed

Generated unittests break with phpunit 9 (required by the v10 testingframework) #436

cypelt opened this issue Aug 5, 2021 · 0 comments · Fixed by #441
Projects

Comments

@cypelt
Copy link

cypelt commented Aug 5, 2021

Describe the bug
Testing attributes has been removed from phpunit sebastianbergmann/phpunit#3339 (comment)
calls like self::assertAttributeEquals break
To Reproduce
run the unit tests of setters generated by the extension builder
Expected behavior
do not generate broken unit tests.

TYPO3 Version
v10, phpunit 9
Extension Builder Version:
v10.0.1

Additional context
as stated in the thread, this is considered bad practice (protected/private attributes). So to test if the attribute has been set we need to check it via the "public api" which would be the getter.

@simonschaufi simonschaufi added this to To do in Budget via automation Aug 16, 2021
@simonschaufi simonschaufi added this to the Next v10 release milestone Aug 16, 2021
Budget automation moved this from To do to Done Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants