Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not tag "RequestBodyParamConverter" as final. #2366

Open
gusdecool opened this issue Apr 15, 2022 · 0 comments
Open

Do not tag "RequestBodyParamConverter" as final. #2366

gusdecool opened this issue Apr 15, 2022 · 0 comments

Comments

@gusdecool
Copy link

Please do not mark class "FOS\RestBundle\Request\RequestBodyParamConverter" as final. This will allow the user to extend the functionality.

There are scenario where we want to extend its functionality like we want to automatically merge the request body to the entity.

example pseudo code

HTTP req

PUT /foo/1

{
    "name": "new name"
}

The existing entity of Foo with id 1 have name: "old name".

Then in controller we will have the parameter already have merge.

public function update(Foo $body) 
{
    print($body->name)
    // output "new name"
    // the value already merged in controller level
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant