Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message about SensioFrameworkExtraBundle view annotations #1878

Closed
oliverklee opened this issue Mar 7, 2018 · 1 comment
Closed

Error message about SensioFrameworkExtraBundle view annotations #1878

oliverklee opened this issue Mar 7, 2018 · 1 comment

Comments

@oliverklee
Copy link

This happens with friendsofsymfony/rest-bundle version 2.3.1 in our project https://github.com/phpList/rest-api.

Updating the sensio/framework-extra-bundle package from version 5.1.0 to version 5.1.1 (or any later 5.1.x version) causes these error messages:

RuntimeException : You must enable the SensioFrameworkExtraBundle view annotations to use the ViewResponseListener. Did you forget to install and enable the TwigBundle?

This can be seen in these builds (all red ones):
https://travis-ci.org/phpList/rest-api/builds/350436773

I've been able to narrow this down to two changes in the sensio/framework-extra-bundle package where the authors explicitly mention the FOSRestBundle:
sensiolabs/SensioFrameworkExtraBundle#530 (comment)

Reusing the old name has an advantage: it will avoid breaking bundles needing to deal with these services, if they kept support for the previous version of the bundle (I'm looking at FOSRestBundle here).

These are the two corresponding changes:

oliverklee pushed a commit to phpList/rest-api that referenced this issue Mar 7, 2018
sensio/framework-extra-bundle 5.1.1 has renamed some services.
friendsofsymfony/rest-bundle has not yet caught up with the new service
IDs, causing all REST routes to break. To work around this until
friendsofsymfony/rest-bundle has fixed this, sensio/framework-extra-bundle
is pinned to version 5.1.0.

This is the corresponding bug report:
FriendsOfSymfony/FOSRestBundle#1878
samtuke pushed a commit to phpList/rest-api that referenced this issue Mar 7, 2018
sensio/framework-extra-bundle 5.1.1 has renamed some services.
friendsofsymfony/rest-bundle has not yet caught up with the new service
IDs, causing all REST routes to break. To work around this until
friendsofsymfony/rest-bundle has fixed this, sensio/framework-extra-bundle
is pinned to version 5.1.0.

This is the corresponding bug report:
FriendsOfSymfony/FOSRestBundle#1878
@xabbuh
Copy link
Member

xabbuh commented Mar 21, 2018

You are right. But we already have an open issue for this. So I am closing here in favour of #1812.

@xabbuh xabbuh closed this as completed Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants