Bugfix when baseurl is missing or empty in json #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Ousret |
tobias-93
added a commit
that referenced
this pull request
Jan 13, 2020
This reverts commit 3c70635.
tobias-93
added a commit
that referenced
this pull request
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 馃憢,
I am proposing this PR in order to fix bad url generation when using symfony flex, webpack encore and fosjsrouting json generation.
As a project can be hosted with different domain name, it is complicated to hardcode into our sources.
This is a minor change. We are verifying if baseurl exist and is not empty to use it as is, else we use window.location to guide us.
Thank you for this amazing project !
Bye.