Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement WarmableInterface #360

Open
bpolaszek opened this issue Jul 8, 2019 · 0 comments
Open

Implement WarmableInterface #360

bpolaszek opened this issue Jul 8, 2019 · 0 comments

Comments

@bpolaszek
Copy link

Hey there,

I just figured out that calling the fos_js_routing_js will trigger a cache write in the %kernel.project_dir%/var/cache/%kernel.environment%/fosJsRouting directory (which doesn't exist in case of a cache miss).

This has 2 drawbacks:

Why not implementing a Symfony\Component\HttpKernel\CacheWarmer\WarmableInterface service which would hook on the cache:clear and the cache:warmup commands to write everything needed during deployment and/or cache clear/warmup?

Pre-requisites are prior knowledge of all the locales used but this can be achieved through the bundle configuration.

What are your thoughts?

@bpolaszek bpolaszek changed the title Implement Symfony\Component\HttpKernel\CacheWarmer\WarmableInterface Implement WarmableInterface Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant