adapt for symfony 4.1 i18n routes #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanza
force-pushed
the
symfony-4.1-i18n
branch
from
92dd1dd
to
cf2247f
Compare
|
+1 |
1 similar comment
|
+1 |
|
Looking good to me. Anyone with localized routes already tried this? |
|
Is this will be merged? |
|
@lordjancso I asked whether it is working since I have no project using localized routes (yet). Nobody answered so I see no reason to merge right now. In case it is tested and working I will merge it. |
|
@alexanza Please, pull the newest version to your code, then I will test it. |
alexanza
force-pushed
the
symfony-4.1-i18n
branch
from
cf2247f
to
b654bf6
Compare
|
@lordjancso done ;) |
|
It is tested and works very well! 👍 |
|
yes, we've been using this feature branch for a while now in one of our applications and works like a charm! |
|
Thanks, good work @alexanza! |
This was referenced Aug 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I adapted the code to work with the i18n routes of symfony 4.1, I hope I did it correctly