From 9493cbd025a4557022e4646561f546058058199a Mon Sep 17 00:00:00 2001 From: Vincent Langlet Date: Thu, 11 May 2023 13:17:21 +0200 Subject: [PATCH] Prefer static call and precise exception --- Controller/Controller.php | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Controller/Controller.php b/Controller/Controller.php index 22f8305..b320347 100644 --- a/Controller/Controller.php +++ b/Controller/Controller.php @@ -20,7 +20,7 @@ use Symfony\Component\HttpFoundation\Request; use Symfony\Component\HttpFoundation\Response; use Symfony\Component\HttpFoundation\Session\Flash\AutoExpireFlashBag; -use Symfony\Component\HttpKernel\Exception\HttpException; +use Symfony\Component\HttpKernel\Exception\BadRequestHttpException; /** * Controller class. @@ -82,9 +82,8 @@ public function indexAction(Request $request, $_format): Response $content = $this->serializer->serialize($routesResponse, 'json'); if (null !== $callback = $request->query->get('callback')) { - $validator = new \JsonpCallbackValidator(); - if (!$validator->validate($callback)) { - throw new HttpException(400, 'Invalid JSONP callback value'); + if (!\JsonpCallbackValidator::validate($callback)) { + throw new BadRequestHttpException('Invalid JSONP callback value'); } $content = '/**/'.$callback.'('.$content.');';