Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that element have at least one value #1519

Merged
merged 1 commit into from May 29, 2019

Conversation

biozshock
Copy link
Contributor

@biozshock biozshock commented May 13, 2019

According to symfony/symfony#20356

@killerwolf
Copy link

killerwolf commented May 27, 2019

The following Deprecation is raised, the current PR will fix it:

Using Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition::cannotBeEmpty() at path "fos_elastica.clients..connections..http_error_codes" has no effect, consider requiresAtLeastOneElement() instead. In 4.0 both methods will behave the same.

@XWB XWB merged commit 501c52c into FriendsOfSymfony:master May 29, 2019
@XWB
Copy link
Member

XWB commented May 29, 2019

Thanks :)

@biozshock biozshock deleted the patch-1 branch May 30, 2019 08:01
@biozshock
Copy link
Contributor Author

@XWB may we have a new tag?

@blackarcanis
Copy link

Not sure to understand how we can avoid this depreciation message...
I'm using the 5.1 version of ElasticaBundle on last 3.4 Symfony version and I would like to not have this depreciation message anymore. Anything I can do ?

@biozshock
Copy link
Contributor Author

@blackarcanis Easy! This PR is not yet have a tag. Latest version 5.1.0 does not have it yet: https://github.com/FriendsOfSymfony/FOSElasticaBundle/blob/v5.1.0/src/DependencyInjection/Configuration.php#L461
Just wait till new tag is released.

@blackarcanis
Copy link

@biozshock OK great, thank you ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants