Allow setting transport connection persistency #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks :) |
|
No problem @XWB What are your plans for a new release? Do these 60+ new commits on master contain any breaking changes in regards to 5.0.3 (the latest release which is a year old)? |
|
@damijank The next release should be 6.0 as there are some BC breaks in master. This will also allow us to refactor the configuration (for example, multiple types within an index are deprecated since Elasticsearch 6). |
|
@XWB too bad 😞 So for the time being we have to (and already have) override this... we're using this in a long-running process (a RMQ worker) and with a persistent connection every so often this raises an exception. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ES services, especially the managed ones (like Azure's), tend to break a connection if it's idle long enough. This PR introduces a configuration setting to be propagated through to the transport layer setup, allowing to use a non-persistent connection (the implicit default there is a persistent connection).