DX: Narrow docblock types in Runner and Report #6465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmajor
commented
Jul 8, 2022
jrmajor
commented
Jul 8, 2022
keradus
reviewed
Jul 10, 2022
Comment on lines
-34
to
+33
| /** @var null|string[] $builtInReporters */ | ||
| /** @var null|list<string> $builtInReporters */ |
There was a problem hiding this comment.
You have already started that discussion in #6293, please see #6293 (comment) and let me know whether that convinces you or do you still want me to revert these changes :)
keradus
reviewed
Jul 10, 2022
jrmajor
force-pushed
the
sca/runner
branch
3 times, most recently
from
cb28c89
to
a7ea63a
Compare
julienfalque
approved these changes
Jul 19, 2022
|
Thank you @jrmajor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.