Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor: extract NoMultipleStatementsPerLineFixer from BracesFixer #6458

Merged
merged 3 commits into from Jul 21, 2022
Merged

minor: extract NoMultipleStatementsPerLineFixer from BracesFixer #6458

merged 3 commits into from Jul 21, 2022

Conversation

julienfalque
Copy link
Member

Extracted from #4884.

@julienfalque julienfalque mentioned this pull request Jul 5, 2022
Merged
6 tasks
@coveralls
Copy link

coveralls commented Jul 5, 2022 •
edited

Coverage Status

Coverage increased (+0.005%) to 92.903% when pulling 72a4b81 on julienfalque:split-braces-fixer-extract into f408220 on FriendsOfPHP:master.

@mvorisek
Copy link
Contributor

why there is no code removed from BracesFixer?

@julienfalque
Copy link
Member Author

I made some cleanup :)

@julienfalque
Copy link
Member Author

Now I remember why: some integration tests fail when removing this code. This requires more work from #4884.

@SpacePossum
Copy link
Contributor

looking good, please consider julienfalque#12

@julienfalque julienfalque merged commit 505adc1 into PHP-CS-Fixer:master Jul 21, 2022
@julienfalque julienfalque deleted the split-braces-fixer-extract branch July 21, 2022 18:41
@SpacePossum SpacePossum mentioned this pull request Aug 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@julienfalque @coveralls @mvorisek @SpacePossum