NoTrailingCommaInSinglelineFunctionCallFixer - Introduction

[SpacePossum]

closes #6141

[coveralls]

Coverage increased (+0.02%) to 93.126% when pulling cb4c02a on SpacePossum:master_NoTrailingCommaInSinglelineFunctionCallFixer into 0b96918 on FriendsOfPHP:master.

[kubawerlos]

Now we have 4 places we remove trailing comma in single line stuff:

• fixer no_trailing_comma_in_list_call
• fixer no_trailing_comma_in_singleline_array
• fixer no_trailing_comma_in_singleline_function_call
• option trailing_comma_single_line in fixer function_declaration

Can we go instead with one fixer like there is trailing_comma_in_multiline?

[SpacePossum]

We could if someone wants to raise the PR and do all the paperwork around deprecations and such. For me it is 50/50, it makes sense to have it done by for example function_declaration, but also by a dedicated rule, I see both sides so I went with this.

[kubawerlos]

Why this way, not:

            $tokens->removeTrailingWhitespace($beforeEndIndex);
            $tokens->clearAt($beforeEndIndex);

as it's done in NoTrailingCommaInSinglelineArrayFixer?

[SpacePossum]

not sure I follow, what would be the benefit?

[kubawerlos]

Consistency, better fixing - now code:

$a = [1, 2, 3, ];
foo(1, 2, 3, );

would be changed to:

$a = [1, 2, 3];
foo(1, 2, 3 );

I cannot imagine anyone want to have the comma removed and keep it's trailing whitespace.

[SpacePossum]

check, I didn't even know removeTrailingWhitespace existed, I think your case is covered through single-responsibility of the rule combined with priorities, but if there is more room for improvement than lets PR it.