Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateTimeCreateFromFormatCallFixer - Introduction #6286

Merged
merged 1 commit into from Mar 18, 2022
Merged

DateTimeCreateFromFormatCallFixer - Introduction #6286

merged 1 commit into from Mar 18, 2022

Conversation

liquid207
Copy link
Contributor

Closes #6133

@liquid207 liquid207 force-pushed the feature-add-create-from-format-fixer branch from f977829 to 90f4c4c Compare February 14, 2022 06:45
@coveralls
Copy link

coveralls commented Feb 14, 2022 •
edited

Coverage Status

Coverage decreased (-0.003%) to 93.113% when pulling 1cda359 on liquid207:feature-add-create-from-format-fixer into d34ccf8 on FriendsOfPHP:master.

@liquid207 liquid207 force-pushed the feature-add-create-from-format-fixer branch from 90f4c4c to 5b42629 Compare February 14, 2022 07:28
@liquid207 liquid207 force-pushed the feature-add-create-from-format-fixer branch from 5b42629 to e6c8569 Compare February 28, 2022 10:15
@liquid207
Copy link
Contributor Author

@keradus Very helpful reviews, thanks.

@liquid207 liquid207 requested a review from keradus March 1, 2022 06:15
@keradus
Copy link
Member

keradus commented Mar 5, 2022

Please avoid force-pushes next time. Now, I have to review everything instead of checking the changes only

@liquid207 liquid207 force-pushed the feature-add-create-from-format-fixer branch from dd9b46e to 2090f0c Compare March 8, 2022 05:32
@liquid207 liquid207 force-pushed the feature-add-create-from-format-fixer branch from 2090f0c to 2e156d2 Compare March 9, 2022 06:40
@SpacePossum
Copy link
Contributor

SpacePossum commented Mar 9, 2022 •
edited

@liquid207
Not sure about the force push, but now all the fixes here liquid207#2 are in conflict.
Is there anything you want me to help with the PR? As it sits now it cannot be merged IMHO given the namespace issue.

@liquid207 liquid207 force-pushed the feature-add-create-from-format-fixer branch from bbabf9f to bced21c Compare March 10, 2022 01:57
@liquid207
Copy link
Contributor Author

@SpacePossum
Sorry for my force push.. I resolve the conflicts and merged your PR to my branch, and fix a little bug, now all changes in here.

SpacePossum
SpacePossum approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@SpacePossum SpacePossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks solid to me, thanks for developing this rule

@SpacePossum
Copy link
Contributor

One last little minor, can you squash into one commit with you as author and committer? It will make a nice single commit new feature and the PR will be marked as merged and not as closed.

@SpacePossum SpacePossum changed the title Add a fixer used to add ! prefix to the first argument of DateTime::createFromFormat DateTimeCreateFromFormatCallFixer - Introduction Mar 10, 2022
@liquid207 liquid207 force-pushed the feature-add-create-from-format-fixer branch from bced21c to 2bad1a9 Compare March 11, 2022 01:49
@liquid207 @keradus
Add a fixer used to add ! prefix to the first argument of DateTime:…
1cda359 
…:createFromFormat

Co-authored-by: Dariusz Rumiński <dariusz.ruminski@gmail.com>
@liquid207 liquid207 force-pushed the feature-add-create-from-format-fixer branch from 2bad1a9 to 1cda359 Compare March 11, 2022 01:50
@liquid207
Copy link
Contributor Author

squashed, @keradus @SpacePossum Thanks for your help.

@keradus
Copy link
Member

keradus commented Mar 18, 2022

Thank you @liquid207.

@keradus keradus merged commit d11e75f into PHP-CS-Fixer:master Mar 18, 2022
@SpacePossum
Copy link
Contributor

thanks @liquid207 , nice one 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus keradus approved these changes

@SpacePossum SpacePossum SpacePossum approved these changes

Assignees
No one assigned
Labels
kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DateTime - add ! prefix
4 participants
@liquid207 @coveralls @keradus @SpacePossum