SingleLineCommentSpacingFixer - Introduction #6274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbalandan
reviewed
Feb 7, 2022
|
why is such fixer useful and enabled by in example https://github.com/atk4/ui/runs/5461667530?check_suite_focus=true we are used to put space after // when it is a "comment that should stay" but if some "code is commented temporary", there is no space this is a semantic convection and help the develop to understand temporary commented code vs. regular comment |
That is set is for this project itself and we do not follow the rule for comments that you describe. The rule is in clear conflict with your (teams) convention, but not with this project. As such, I would recommend not using the rule set for this project but to create you own config for your project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.