Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhpUnitDedicateAssertFixer - remove is_resource. #6254

Closed
wants to merge 1 commit into from
Closed

PhpUnitDedicateAssertFixer - remove is_resource. #6254

wants to merge 1 commit into from

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Jan 25, 2022

This PR:

  • Update phpunit_dedicate_assert fixer

Fix #6179

@drupol
Copy link
Contributor Author

drupol commented Jan 25, 2022

@SpacePossum Here you go, let me know if there is something left to do.

@coveralls
Copy link

coveralls commented Jan 25, 2022 •
edited

Coverage Status

Coverage remained the same at 93.172% when pulling 2b1ecae on drupol:6179-do-not-replace-is_resource into 55aec39 on FriendsOfPHP:master.

@SpacePossum SpacePossum changed the title #6179: Do not replace is_resource(). PhpUnitDedicateAssertFixer - remove is_resource. Jan 25, 2022
@SpacePossum
Copy link
Contributor

Thank you @drupol.

@SpacePossum SpacePossum removed the RTM Ready To Merge label Feb 4, 2022
@drupol drupol deleted the 6179-do-not-replace-is_resource branch February 4, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus keradus left review comments

Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule php_unit_dedicate_assert should not use assertInternalType anymore.
4 participants
@drupol @coveralls @SpacePossum @keradus