Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DX: Application - better display version when displaying gitSha #6237

Merged
merged 1 commit into from Jan 18, 2022
Merged

DX: Application - better display version when displaying gitSha #6237

merged 1 commit into from Jan 18, 2022

Conversation

keradus
Copy link
Member

@keradus keradus commented Jan 14, 2022 •
edited

before the change of this PR, but after #6222 :

ker@dus:~/github/PHP-CS-Fixer λ ./php-cs-fixer.phar 
PHP CS Fixer 3.5.0 The Creation by Fabien Potencier and Dariusz Ruminski.
PHP runtime: 8.0.13 (333f15e)

it's misleading, as 333f15e is gitSha of Fixer, not of PHP runtime

@coveralls
Copy link

coveralls commented Jan 14, 2022 •
edited

Coverage Status

Coverage increased (+0.0004%) to 93.149% when pulling 1b54c3e on keradus:app_ver into 333f15e on FriendsOfPHP:master.

@SpacePossum
Copy link
Contributor

looks good, but the smoke test need updating as well now ; )

@keradus keradus marked this pull request as draft January 14, 2022 09:53
@keradus keradus force-pushed the app_ver branch 2 times, most recently from e91ab40 to 872c601 Compare January 17, 2022 23:06
@keradus keradus marked this pull request as ready for review January 17, 2022 23:16
@keradus keradus added the RTM Ready To Merge label Jan 17, 2022
@SpacePossum
Copy link
Contributor

Thank you @keradus.

@SpacePossum SpacePossum merged commit 3b3a5f0 into PHP-CS-Fixer:master Jan 18, 2022
@keradus keradus deleted the app_ver branch January 18, 2022 14:02
@keradus keradus removed the RTM Ready To Merge label Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpacePossum SpacePossum SpacePossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@keradus @coveralls @SpacePossum