Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Tokens::isMonolithicPhp #6233

Closed
wants to merge 5 commits into from
Closed

Update Tokens::isMonolithicPhp #6233

wants to merge 5 commits into from

Conversation

kubawerlos
Copy link
Contributor

No description provided.

@kubawerlos kubawerlos mentioned this pull request Jan 12, 2022
Closed
@coveralls
Copy link

coveralls commented Jan 12, 2022 •
edited

Coverage Status

Coverage increased (+0.03%) to 93.144% when pulling 9624c0c on werlos:update_Tokens_isMonolithicPhp into 6fe4c69 on FriendsOfPHP:master.

keradus
keradus reviewed Jan 13, 2022
View reviewed changes
src/Tokenizer/Tokens.php Outdated Show resolved Hide resolved
kubawerlos and others added 3 commits January 13, 2022 22:14
@kubawerlos @keradus
Update tests/Tokenizer/TokensTest.php
fd9d8b3 
Co-authored-by: Dariusz Rumiński <dariusz.ruminski@gmail.com>
@kubawerlos
Update multiline handling
a406b75
@kubawerlos @keradus
Apply suggestions from code review
229b1dc 
Co-authored-by: Dariusz Rumiński <dariusz.ruminski@gmail.com>
keradus
keradus reviewed Jan 13, 2022
View reviewed changes
src/Tokenizer/Tokens.php Outdated Show resolved Hide resolved
@kubawerlos @keradus
Apply suggestions from code review
9624c0c 
Co-authored-by: Dariusz Rumiński <dariusz.ruminski@gmail.com>
@SpacePossum SpacePossum added the RTM Ready To Merge label Jan 13, 2022
@keradus keradus removed the RTM Ready To Merge label Jan 14, 2022
@keradus
Copy link
Member

keradus commented Jan 14, 2022

Thank you @kubawerlos.

keradus added a commit that referenced this pull request Jan 14, 2022
@keradus
minor #6233 Update Tokens::isMonolithicPhp (kubawerlos)
01a0cf4 
This PR was squashed before being merged into the master branch.

Discussion
----------

Update Tokens::isMonolithicPhp

Commits
-------

738972d Update Tokens::isMonolithicPhp
@keradus keradus closed this Jan 14, 2022
@kubawerlos kubawerlos deleted the update_Tokens_isMonolithicPhp branch January 14, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus keradus approved these changes

@SpacePossum SpacePossum SpacePossum approved these changes

Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kubawerlos @coveralls @keradus @SpacePossum