Show runtime on version command #6222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
reviewed
Jan 4, 2022
keradus
reviewed
Jan 4, 2022
keradus
reviewed
Jan 4, 2022
keradus
approved these changes
Jan 12, 2022
SpacePossum
added a commit
that referenced
this pull request
Jan 18, 2022
…gitSha (keradus) This PR was squashed before being merged into the master branch (closes #6237). Discussion ---------- DX: Application - better display version when displaying gitSha before the change of this PR, but after #6222 : ``` ker@dus:~/github/PHP-CS-Fixer λ ./php-cs-fixer.phar PHP CS Fixer 3.5.0 The Creation by Fabien Potencier and Dariusz Ruminski. PHP runtime: 8.0.13 (333f15e) ``` it's misleading, as 333f15e is gitSha of Fixer, not of PHP runtime Commits ------- 1b54c3e DX: Application - better display version when displaying gitSha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show the PHP runtime on version command (php-cs-fixer -V), simplify code.