Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use composer/xdebug-handler v3 #6218

Merged
merged 1 commit into from Jan 9, 2022

Conversation

gharlan
Copy link
Contributor

@gharlan gharlan commented Jan 3, 2022

closes #6213

@coveralls
Copy link

coveralls commented Jan 3, 2022

Coverage Status

Coverage remained the same at 93.115% when pulling 8e29121 on gharlan:xdebug-handler into 8f10396 on FriendsOfPHP:master.

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@SpacePossum SpacePossum added the RTM Ready To Merge label Jan 4, 2022
@gharlan gharlan changed the title Support composer/xdebug-handler v3 Use composer/xdebug-handler v3 Jan 4, 2022
@stof
Copy link
Contributor

stof commented Jan 5, 2022

To reduce the risk of dependency conflicts, I suggest supporting both 2 and 3, as there does not seem to be any change needed in php-cs-fixer between those versions.

@SpacePossum SpacePossum removed the RTM Ready To Merge label Jan 5, 2022
@keradus
Copy link
Member

keradus commented Jan 7, 2022

I'm happy to merge v3 only and reconsider support for v2 if we would see complaints and ppl not updating because of that. ultimately, upcoming shim package would solve the dependencies conflicts once and for all

@keradus keradus added the RTM Ready To Merge label Jan 7, 2022
@SpacePossum
Copy link
Contributor

Thank you @gharlan.

@SpacePossum SpacePossum merged commit 4ba8952 into PHP-CS-Fixer:master Jan 9, 2022
@SpacePossum SpacePossum removed the RTM Ready To Merge label Jan 9, 2022
@ankorstore-haddowg
Copy link

@keradus @SpacePossum please add back support for v2 here.
i am unable to upgrade as the composer/composer package itself has not yet updated its dependency on xdebug-handler and thats a dependency of phpstan which we also use.
looks like there is no reason for this not to support 2 also as the only reason 3 was a major is that it removed compatibility for older php version which this package already no longer supports.

@gharlan gharlan deleted the xdebug-handler branch February 3, 2022 15:16
@SpacePossum
Copy link
Contributor

hi, can you maybe make a PR of it?

@keradus
Copy link
Member

keradus commented Feb 3, 2022

as alternative - would a shim package fix the situation here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow composer/xdebug-handler v3
6 participants