Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NullableTypeDeclarationForDefaultNullValueFixer - fix tests #6210

Merged
merged 1 commit into from Jan 2, 2022
Merged

NullableTypeDeclarationForDefaultNullValueFixer - fix tests #6210

merged 1 commit into from Jan 2, 2022

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Dec 28, 2021

Bug caused by #5925

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.042% when pulling b61175d on HypeMC:nullable-type-declaration-tests-fix into e67580b on FriendsOfPHP:master.

@HypeMC HypeMC mentioned this pull request Dec 28, 2021
Merged
@kubawerlos kubawerlos added kind/bug RTM Ready To Merge labels Dec 28, 2021
@keradus
Copy link
Member

keradus commented Dec 29, 2021

Bug caused by #5925

The change proposed in this PR is good, but it was rather introduced in
https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/6034/files#diff-9606d9edb53ba9be8b1ae84ff57d80593a59c0b079c33e5e3049f610fe537cbcR396-R398
than in
https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5925/files#diff-9606d9edb53ba9be8b1ae84ff57d80593a59c0b079c33e5e3049f610fe537cbcL400-L404

@SpacePossum
Copy link
Contributor

Thank you @HypeMC.

@SpacePossum SpacePossum merged commit c36f996 into PHP-CS-Fixer:master Jan 2, 2022
@SpacePossum SpacePossum removed the RTM Ready To Merge label Jan 2, 2022
@HypeMC HypeMC deleted the nullable-type-declaration-tests-fix branch January 2, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell approved these changes

@kubawerlos kubawerlos kubawerlos approved these changes

@SpacePossum SpacePossum SpacePossum approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@HypeMC @coveralls @keradus @SpacePossum @GrahamCampbell @kubawerlos