Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: DiffConsoleFormatter - escape - #6190

Merged
merged 1 commit into from Dec 20, 2021
Merged

Conversation

keradus
Copy link
Member

@keradus keradus commented Dec 16, 2021

https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/6183/files#r770714802

Original form, depending on language or analyser, may trigger a warning.

https://www.regular-expressions.info/charclass.html
In most regex flavors, the only special characters or metacharacters inside a character class are the closing bracket ], the backslash , the caret ^, and the hyphen -. The usual metacharacters are normal characters inside a character class, and do not need to be escaped by a backslash

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.037% when pulling 23aaa2e on keradus:6183b into 1f4f55a on FriendsOfPHP:master.

@kubawerlos kubawerlos added the RTM Ready To Merge label Dec 16, 2021
@SpacePossum
Copy link
Contributor

Thank you @keradus.

@SpacePossum SpacePossum merged commit a0fe01e into PHP-CS-Fixer:master Dec 20, 2021
@SpacePossum SpacePossum removed the RTM Ready To Merge label Dec 20, 2021
@keradus keradus deleted the 6183b branch December 20, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants