Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not support array of patterns in Preg methods #6184

Merged
merged 1 commit into from Dec 16, 2021
Merged

Do not support array of patterns in Preg methods #6184

merged 1 commit into from Dec 16, 2021

Conversation

kubawerlos
Copy link
Contributor

@kubawerlos kubawerlos commented Dec 15, 2021 •
edited

Requires #6183 to be merged.

Preg is an internal class, so BC break is fine.

To be continued: #6185.

This was referenced Dec 15, 2021
Merged
Merged
SpacePossum added a commit that referenced this pull request Dec 16, 2021
@SpacePossum
minor #6183 Simplify DiffConsoleFormatter (kubawerlos)
b4b6d13 
This PR was merged into the master branch.

Discussion
----------

Simplify DiffConsoleFormatter

This is actually only place where any `Preg` method is called with an array (of patterns), not a string.

To be continued: #6184.

Commits
-------

cf4dcc4 Simplify DiffConsoleFormatter
@SpacePossum
Copy link
Contributor

please rebase :)

@kubawerlos kubawerlos marked this pull request as ready for review December 16, 2021 08:24
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 93.037% when pulling b610b92 on werlos:do_not_support_arrays_in_Preg_methods into b4b6d13 on FriendsOfPHP:master.

@SpacePossum
Copy link
Contributor

Thank you @kubawerlos.

@SpacePossum SpacePossum merged commit d23cc90 into PHP-CS-Fixer:master Dec 16, 2021
@kubawerlos kubawerlos deleted the do_not_support_arrays_in_Preg_methods branch December 16, 2021 08:45
SpacePossum added a commit that referenced this pull request Dec 16, 2021
@SpacePossum
minor #6185 Upgrade PHPStan (kubawerlos)
1f4f55a 
This PR was merged into the master branch.

Discussion
----------

Upgrade PHPStan

Requires #6184 to be merged.

After merging the PR above CI will be green.

The end 🎆

As an extra you can see here PHPStan error annotation in the diff (until it is fixed of course).

Commits
-------

5661979 Upgrade PHPStan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kubawerlos @SpacePossum @coveralls