Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify DiffConsoleFormatter #6183

Merged
merged 1 commit into from Dec 16, 2021
Merged

Simplify DiffConsoleFormatter #6183

merged 1 commit into from Dec 16, 2021

Conversation

kubawerlos
Copy link
Contributor

@kubawerlos kubawerlos commented Dec 15, 2021 •
edited

This is actually only place where any Preg method is called with an array (of patterns), not a string.

To be continued: #6184.

@kubawerlos kubawerlos mentioned this pull request Dec 15, 2021
Merged
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.048% when pulling cf4dcc4 on werlos:simplify_DiffConsoleFormatter into 24999a0 on FriendsOfPHP:master.

@SpacePossum
Copy link
Contributor

Thank you @kubawerlos.

@SpacePossum SpacePossum merged commit b4b6d13 into PHP-CS-Fixer:master Dec 16, 2021
@kubawerlos kubawerlos deleted the simplify_DiffConsoleFormatter branch December 16, 2021 08:22
SpacePossum added a commit that referenced this pull request Dec 16, 2021
@SpacePossum
minor #6184 Do not support array of patterns in Preg methods (kubawer…
d23cc90 
…los)

This PR was merged into the master branch.

Discussion
----------

Do not support array of patterns in Preg methods

Requires #6183 to be merged.

`Preg` is an internal class, so BC break is fine.

To be continued: #6185.

Commits
-------

b610b92 Do not support array of patterns in Preg methods
keradus
keradus reviewed Dec 16, 2021
View reviewed changes
src/Differ/DiffConsoleFormatter.php
'/^(\-.*)/',
'/^(@.*)/',
],
'/^([+-@].*)/',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus keradus left review comments

Assignees
No one assigned
Labels
kind/cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kubawerlos @coveralls @SpacePossum @keradus