Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests and CS #6171

Merged
merged 1 commit into from Dec 14, 2021
Merged

Fix tests and CS #6171

merged 1 commit into from Dec 14, 2021

Conversation

SpacePossum
Copy link
Contributor

No description provided.

@SpacePossum SpacePossum marked this pull request as draft December 14, 2021 07:05
@coveralls
Copy link

coveralls commented Dec 14, 2021 •
edited

Coverage Status

Coverage increased (+0.0004%) to 93.024% when pulling e4c4b9f on SpacePossum:master_failing_tests into 4ecba58 on FriendsOfPHP:master.

@SpacePossum SpacePossum marked this pull request as ready for review December 14, 2021 07:56
@SpacePossum SpacePossum changed the title show PHP version when running phpunit Fix tests and CS Dec 14, 2021
@SpacePossum SpacePossum merged commit ea5a185 into PHP-CS-Fixer:master Dec 14, 2021
@SpacePossum SpacePossum deleted the master_failing_tests branch December 14, 2021 08:16
keradus
keradus reviewed Dec 14, 2021
View reviewed changes
.github/workflows/ci.yml
@@ -124,7 +124,9 @@ jobs:
env:
PHP_CS_FIXER_IGNORE_ENV: ${{ matrix.PHP_CS_FIXER_IGNORE_ENV }}
FAST_LINT_TEST_CASES: ${{ matrix.FAST_LINT_TEST_CASES }}
run: vendor/bin/phpunit ${{ matrix.phpunit-flags }}
run: |
php -v
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SpacePossum
why we need this?
isn't it already part of the workflow, to set up configured version of PHP?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> #6172

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah if test locally work but no gitlab it is very much handly to know the patch version (like 8.0.0 vs. 8.0.1)

@keradus keradus mentioned this pull request Dec 14, 2021
Closed
SpacePossum added a commit that referenced this pull request Dec 15, 2021
@SpacePossum
minor #6172 DX: Tokens::insertSlices - groom code and fix tests (kera…
d81884c 
…dus)

This PR was squashed before being merged into the master branch (closes #6172).

Discussion
----------

DX: Tokens::insertSlices - groom code and fix tests

follows up #6171

Commits
-------

8b0df85 DX: Tokens::insertSlices - groom code and fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus keradus left review comments

Assignees
No one assigned
Labels
topic/tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SpacePossum @coveralls @keradus