Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NonPrintableCharacterFixer - fix for string in single quotes, having non-breaking space, linebreak, and single quote inside #6170

Closed
wants to merge 2 commits into from

Conversation

kubawerlos
Copy link
Contributor

In the topic of edge cases - this one is awesome, the title says it all.

Don't give me any credits for this, I'm not that smart to came with this one - all the glory goes to Google.

see it at your own risk, not the prettiest code you'll ever see: https://github.com/googleapis/google-cloud-php/blob/v0.172.0/Compute/metadata/V1/Compute.php.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.034% when pulling f8d16dc on werlos:fix_NonPrintableCharacterFixer into 2c944f8 on FriendsOfPHP:master.

@SpacePossum
Copy link
Contributor

Thank you @kubawerlos.

@kubawerlos kubawerlos deleted the fix_NonPrintableCharacterFixer branch December 14, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants