Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 2nd parameter to XdebugHandler constructor #6127

Merged

Conversation

phil-davis
Copy link
Contributor

It was removed in composer/xdebug-handler#123 composer/XdebugHandler v2.
Issue composer/xdebug-handler#131 has some discussion.

@SpacePossum SpacePossum added kind/cleanup RTM Ready To Merge labels Nov 26, 2021
@SpacePossum
Copy link
Contributor

Thanks for opening the PR @phil-davis 👍

Looks good to me and ready for merge as soon as the tests have run :)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.853% when pulling 005907e on phil-davis:remove-XdebugHandler-2nd-parameter into 07430f5 on FriendsOfPHP:master.

@SpacePossum
Copy link
Contributor

Thank you @phil-davis.

@SpacePossum SpacePossum merged commit 39df457 into PHP-CS-Fixer:master Nov 26, 2021
@SpacePossum SpacePossum removed the RTM Ready To Merge label Nov 26, 2021
@phil-davis phil-davis deleted the remove-XdebugHandler-2nd-parameter branch November 26, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants