Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add return type to DummyTestSplFileInfo::getRealPath() #6109

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Add return type to DummyTestSplFileInfo::getRealPath() #6109

merged 1 commit into from
Nov 26, 2021

Conversation

derrabus
Copy link
Contributor

PHP 8.1 emits a deprecation warning if that method does not declare a return type. So I've added it.

@derrabus
Add return type to DummyTestSplFileInfo::getRealPath()
03d61aa 
Signed-off-by: Alexander M. Turek <me@derrabus.de>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.853% when pulling 03d61aa on derrabus:bugfix/get-real-path-deprecation into 07430f5 on FriendsOfPHP:master.

@SpacePossum SpacePossum added topic/tests RTM Ready To Merge labels Nov 16, 2021
@SpacePossum
Copy link
Contributor

Thank you @derrabus.

@SpacePossum SpacePossum merged commit 8172ed2 into PHP-CS-Fixer:master Nov 26, 2021
@SpacePossum SpacePossum removed the RTM Ready To Merge label Nov 26, 2021
@derrabus derrabus deleted the bugfix/get-real-path-deprecation branch November 26, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienfalque julienfalque julienfalque approved these changes

@SpacePossum SpacePossum SpacePossum approved these changes

Assignees
No one assigned
Labels
topic/tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@derrabus @coveralls @SpacePossum @julienfalque