Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum PHP version to 7.2 #6067

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Bump minimum PHP version to 7.2 #6067

merged 1 commit into from
Nov 15, 2021

Conversation

keradus
Copy link
Member

@keradus keradus commented Oct 12, 2021

@coveralls
Copy link

coveralls commented Oct 12, 2021 •
edited

Coverage Status

Coverage remained the same at 92.853% when pulling a4b59f0 on keradus:71 into 66b2a5d on FriendsOfPHP:master.

@GrahamCampbell
Copy link
Contributor

Are there data providers and unnecessary skipping to clean up in the tests?

@keradus
Copy link
Member Author

keradus commented Oct 17, 2021

potentially, there are.
yet, that cleanup is not providing the biggest value to justify prioritizing effort for it

@GrahamCampbell
Copy link
Contributor

Fair.

GrahamCampbell
GrahamCampbell approved these changes Oct 17, 2021
View reviewed changes
Copy link
Contributor

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send it. 🚀

@julienfalque
Copy link
Member

Maybe we can remove Symfony 4.x components dependencies?

@keradus
Copy link
Member Author

keradus commented Nov 8, 2021

when I checked initially there was somemething still blocking, but maybe it's no longer the case. I was also thinking about lower PHPUnit. Let's check after this one is merged

@keradus keradus merged commit 96a9f4f into PHP-CS-Fixer:master Nov 15, 2021
@keradus keradus deleted the 71 branch November 15, 2021 17:42
@keradus keradus mentioned this pull request Nov 15, 2021
Merged
SpacePossum added a commit that referenced this pull request Nov 26, 2021
@SpacePossum
minor #6107 Drop support of PHPUnit v7 dependency (keradus)
6d0b9cc 
This PR was merged into the master branch.

Discussion
----------

Drop support of PHPUnit v7 dependency

ref #6067 (comment)

Commits
-------

46b3f85 Drop support of PHPUnit v7 dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

@julienfalque julienfalque julienfalque approved these changes

@GrahamCampbell GrahamCampbell GrahamCampbell approved these changes

@SpacePossum SpacePossum SpacePossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@keradus @coveralls @GrahamCampbell @julienfalque @derrabus @SpacePossum