New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GetClassToClassKeywordFixer - introduction #5953
Merged
SpacePossum
merged 1 commit into
PHP-CS-Fixer:master
from
paulbalandan:get-class-to-class-keyword
Dec 14, 2021
Merged
GetClassToClassKeywordFixer - introduction #5953
SpacePossum
merged 1 commit into
PHP-CS-Fixer:master
from
paulbalandan:get-class-to-class-keyword
Dec 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
paulbalandan
commented
Sep 4, 2021
paulbalandan
force-pushed
the
get-class-to-class-keyword
branch
from
September 4, 2021 16:06
2a7fa99
to
30d7386
Compare
paulbalandan
force-pushed
the
get-class-to-class-keyword
branch
2 times, most recently
from
September 4, 2021 16:40
a60de76
to
752a326
Compare
kubawerlos
reviewed
Sep 5, 2021
I always considered accessing class constants via object instances a hacky/bad practice, is it not? |
paulbalandan
force-pushed
the
get-class-to-class-keyword
branch
from
September 5, 2021 11:51
752a326
to
3be174a
Compare
I would agree if we talk about class constant defined as part of class.
|
paulbalandan
force-pushed
the
get-class-to-class-keyword
branch
from
September 13, 2021 12:56
3be174a
to
6b808cc
Compare
paulbalandan
force-pushed
the
get-class-to-class-keyword
branch
from
October 1, 2021 05:11
6b808cc
to
c5a3dc0
Compare
keradus
approved these changes
Oct 5, 2021
keradus
force-pushed
the
get-class-to-class-keyword
branch
from
October 5, 2021 07:12
c91a4dd
to
0337605
Compare
paulbalandan
force-pushed
the
get-class-to-class-keyword
branch
from
October 5, 2021 09:03
0337605
to
c87dbde
Compare
keradus
reviewed
Oct 5, 2021
paulbalandan
force-pushed
the
get-class-to-class-keyword
branch
3 times, most recently
from
October 6, 2021 03:54
05b95ef
to
168a345
Compare
SpacePossum
reviewed
Oct 11, 2021
looking good! 👍 |
SpacePossum
added a commit
that referenced
this pull request
Dec 14, 2021
…okens (paulbalandan, SpacePossum) This PR was squashed before being merged into the master branch (closes #6058). Discussion ---------- Fix `Tokens::insertSlices` not moving around all affected tokens While working on #5953 in refactoring to call `insertSlices` once, I stumbled into a problem where parse error would appear after fixing. After digging into it more, I found out that the culprit is in the `insertSlices` method itself. If there are multiple slices to be inserted in an index and this is repeated in other indexes, there exists a "hole" left in the moving around of tokens. This causes the unmoved tokens to be inadvertently replaced by other else possibly resulting to parse errors after. Commits ------- fbac555 Fix `Tokens::insertSlices` not moving around all affected tokens
SpacePossum
force-pushed
the
get-class-to-class-keyword
branch
2 times, most recently
from
December 14, 2021 06:55
de85002
to
c7980d4
Compare
SpacePossum
force-pushed
the
get-class-to-class-keyword
branch
from
December 14, 2021 08:17
c7980d4
to
ee541a6
Compare
Thank you @paulbalandan. |
Thanks, @SpacePossum |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.