Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DX: ProjectCodeTest - fix detection by testExpectedInputOrder #5925

Merged
merged 1 commit into from
Sep 4, 2021
Merged

DX: ProjectCodeTest - fix detection by testExpectedInputOrder #5925

merged 1 commit into from
Sep 4, 2021
+142 −80

Conversation

keradus
Copy link
Member

@keradus keradus commented Aug 30, 2021

No description provided.

@keradus
Copy link
Member Author

keradus commented Aug 31, 2021

@fabpot , fabbot.io is wrong here, it assumes it runs on Symfony. maybe it could run rules depending on repos (default rules or default+Symfony rules?)

@keradus keradus added this to the 3.1.1 milestone Sep 1, 2021
@GrahamCampbell
Copy link
Contributor

Merge conflicts. 😭

@keradus
Copy link
Member Author

keradus commented Sep 4, 2021

not sure what this comment brings to discussion, each of us can see it, no need to fingerprint it 🤷

@keradus keradus force-pushed the dx_project_code_expected_order branch from 03b22c9 to e36a05f Compare September 4, 2021 13:03
@keradus keradus modified the milestones: 3.1.1, 3.2.0 Sep 4, 2021
@coveralls
Copy link

coveralls commented Sep 4, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 92.34% when pulling 2b027e7 on keradus:dx_project_code_expected_order into 780bbb8 on FriendsOfPHP:master.

@keradus keradus force-pushed the dx_project_code_expected_order branch from e36a05f to 2b027e7 Compare September 4, 2021 13:26
@keradus keradus merged commit cdfd00b into PHP-CS-Fixer:master Sep 4, 2021
@keradus keradus deleted the dx_project_code_expected_order branch September 4, 2021 13:28
@HypeMC HypeMC mentioned this pull request Dec 28, 2021
Merged
SpacePossum added a commit that referenced this pull request Jan 2, 2022
@SpacePossum
minor #6210 NullableTypeDeclarationForDefaultNullValueFixer - fix tes…
c36f996 
…ts (HypeMC)

This PR was merged into the master branch.

Discussion
----------

NullableTypeDeclarationForDefaultNullValueFixer - fix tests

Bug caused by #5925

Commits
-------

b61175d NullableTypeDeclarationForDefaultNullValueFixer - fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubawerlos kubawerlos

Assignees
No one assigned
Labels
kind/enhancement topic/tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@keradus @GrahamCampbell @coveralls @kubawerlos @SpacePossum