Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to PHP 7.0 in tests (with updates) #5906

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Remove references to PHP 7.0 in tests (with updates) #5906

merged 1 commit into from
Aug 31, 2021
+458 −869

Conversation

kubawerlos
Copy link
Contributor

No description provided.

This was referenced Aug 28, 2021
Closed
Merged
@coveralls
Copy link

coveralls commented Aug 28, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 92.311% when pulling 59c3e94 on kubawerlos:remove_references_to_php_7.0_in_tests into 348b7aa on FriendsOfPHP:master.

@kubawerlos kubawerlos marked this pull request as ready for review August 28, 2021 21:47
@keradus keradus changed the base branch from 3.0 to master August 29, 2021 19:08
SpacePossum
SpacePossum approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@SpacePossum SpacePossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert the changes in the BracesFixerTest and than RTM from me :)

@SpacePossum
Copy link
Contributor

Thank you @kubawerlos.

@SpacePossum SpacePossum merged commit a4cdf6c into PHP-CS-Fixer:master Aug 31, 2021
@kubawerlos kubawerlos deleted the remove_references_to_php_7.0_in_tests branch August 31, 2021 15:58
@kubawerlos kubawerlos added this to the 3.1.1 milestone Aug 31, 2021
@keradus keradus removed this from the 3.1.1 milestone Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienfalque julienfalque

@GrahamCampbell GrahamCampbell

@SpacePossum SpacePossum

Assignees
No one assigned
Labels
kind/cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kubawerlos @coveralls @SpacePossum @julienfalque @GrahamCampbell @keradus