Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YodaStyleFixer - yield support #5823

Merged
merged 1 commit into from
Jul 29, 2021
Merged

YodaStyleFixer - yield support #5823

merged 1 commit into from
Jul 29, 2021

Conversation

SpacePossum
Copy link
Contributor

replaces part of #5811

@SpacePossum SpacePossum modified the milestones: 2.19.1, 2.19.2 Jul 28, 2021
@coveralls
Copy link

coveralls commented Jul 28, 2021 •
edited

Coverage Status

Coverage increased (+0.0004%) to 91.559% when pulling d3dc0fb on SpacePossum:2_19_Yoda_yield_support into 7c196db on FriendsOfPHP:2.19.

drupol
drupol approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that this PR is fixing my problem, which is originating from: https://github.com/loophp/collection/blob/master/src/Operation/Same.php#L61

@drupol drupol mentioned this pull request Jul 28, 2021
Closed
1 task
@keradus keradus mentioned this pull request Jul 29, 2021
Closed
@keradus
Copy link
Member

keradus commented Jul 29, 2021

Thank you @SpacePossum.

@keradus keradus merged commit 27dc57d into PHP-CS-Fixer:2.19 Jul 29, 2021
@keradus keradus deleted the 2_19_Yoda_yield_support branch July 29, 2021 21:31
@drupol
Copy link
Contributor

drupol commented Jul 29, 2021

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

@julienfalque julienfalque julienfalque approved these changes

Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
2.19.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SpacePossum @coveralls @keradus @drupol @julienfalque