Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: update PHPStan #5777

Merged
merged 1 commit into from
Jun 27, 2021
Merged

DX: update PHPStan #5777

merged 1 commit into from
Jun 27, 2021

Conversation

kubawerlos
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jun 21, 2021

Coverage Status

Coverage increased (+0.004%) to 91.565% when pulling c613bcf on kubawerlos:update_phpstan into a41998c on FriendsOfPHP:2.19.

@kubawerlos kubawerlos marked this pull request as ready for review June 21, 2021 21:39
@julienfalque julienfalque added this to the 2.19.1 milestone Jun 22, 2021
@kubawerlos kubawerlos added the RTM Ready To Merge label Jun 22, 2021
@keradus keradus removed the RTM Ready To Merge label Jun 27, 2021
@@ -238,10 +238,6 @@ private function getPreviousNewlineTokenIndex(Tokens $tokens, $startIndex)
if ($this->isNewLineToken($tokens, $index)) {
return $this->returnWithUpdateCache($startIndex, $index);
}

if ($this->isNewLineToken($tokens, $index)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@keradus
Copy link
Member

keradus commented Jun 27, 2021

Thank you @kubawerlos.

@keradus keradus merged commit 13cd449 into PHP-CS-Fixer:2.19 Jun 27, 2021
@kubawerlos kubawerlos deleted the update_phpstan branch June 27, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants