Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DX: run static code analysis on PHP 8.0 #5775

Merged
merged 1 commit into from
Oct 27, 2021
Merged

DX: run static code analysis on PHP 8.0 #5775

merged 1 commit into from
Oct 27, 2021

Conversation

kubawerlos
Copy link
Contributor

@kubawerlos kubawerlos commented Jun 21, 2021 •
edited

Waits for new release of php-scoper.

@coveralls
Copy link

coveralls commented Jun 21, 2021 •
edited

Coverage Status

Coverage remained the same at 92.817% when pulling d1b593e on kubawerlos:run_static_code_analysis_on_php_80 into 0708baf on FriendsOfPHP:master.

keradus
keradus reviewed Jun 28, 2021
View reviewed changes
dev-tools/build.sh Outdated Show resolved Hide resolved
@keradus keradus changed the base branch from 2.19 to 3.0 August 2, 2021 18:06
@kubawerlos kubawerlos mentioned this pull request Aug 8, 2021
Merged
keradus added a commit that referenced this pull request Aug 18, 2021
@keradus
minor #5864 DX: update dev tools (kubawerlos)
3ac7bc9 
This PR was merged into the 3.0 branch.

Discussion
----------

DX: update dev tools

Updates extracted from #5775 that are ready to be merged now.

Commits
-------

fc17338 Update dev tools
@keradus keradus changed the base branch from 3.0 to master August 29, 2021 18:54
@keradus
Copy link
Member

keradus commented Oct 6, 2021

any chance to move out of Draft here?

@kubawerlos
Copy link
Contributor Author

any chance to move out of Draft here?

@keradus want to merge with this:

"humbug/php-scoper": "dev-master as 0.14.2",

?

@keradus
Copy link
Member

keradus commented Oct 6, 2021

can it work for us on 0.15.0?
what exactly we need from PHP scoper? any concrete PR that got merged and not released? maybe we can ask for release?

keradus
keradus reviewed Oct 6, 2021
View reviewed changes
dev-tools/composer.json Outdated Show resolved Hide resolved
@kubawerlos
Copy link
Contributor Author

can it work for us on 0.15.0? what exactly we need from PHP scoper? any concrete PR that got merged and not released? maybe we can ask for release?

No, 0.15.0 won't help us, Scoper in this latest release requires symfony/console up to version 4: https://github.com/humbug/php-scoper/blob/0.15.0/composer.json#L27
ComposerRequireChecker in all versions supporting PHP 8 required symfony/console 5: https://github.com/maglnet/ComposerRequireChecker/blob/3.0.0/composer.json#L34

Scoper on master requires what we need: https://github.com/humbug/php-scoper/blob/master/composer.json so release would solve our problem.

@kubawerlos kubawerlos marked this pull request as ready for review October 7, 2021 15:43
@keradus keradus added the RTM Ready To Merge label Oct 21, 2021
@SpacePossum
Copy link
Contributor

Thank you @kubawerlos.

@SpacePossum SpacePossum merged commit 93a54b3 into PHP-CS-Fixer:master Oct 27, 2021
@SpacePossum SpacePossum removed the RTM Ready To Merge label Oct 27, 2021
@kubawerlos kubawerlos deleted the run_static_code_analysis_on_php_80 branch October 27, 2021 06:31
@kubawerlos kubawerlos mentioned this pull request Aug 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus keradus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kubawerlos @coveralls @keradus @SpacePossum